-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create-react migration to vite #289
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, apparently vite is a better choice for building spa now days, and the pull request does its job with minimal cost. However, there is an issue that needs to be fixed: types for vite
and svgr
are now missing, so tsc
command cannot pass, you can fix it by adding the following declarations to the project:
/// <reference types="vite/client" />
/// <reference types="vite-plugin-svgr/client" />
One more thing, since we are moving from cra
to vite
, maybe the src/react-app-env.d.ts
file is no longer needed?
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #289 +/- ##
==========================================
Coverage ? 65.26%
==========================================
Files ? 39
Lines ? 6161
Branches ? 236
==========================================
Hits ? 4021
Misses ? 2137
Partials ? 3 Continue to review full report in Codecov by Sentry.
|
git rebase is done @Flouse |
error Your lockfile needs to be updated, but yarn was run with All tests have been passed @Flouse |
Thank you! |
主要改动
迁移前后对比:
界面截图
检查清单