-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Network switching strategy adjustment #260
feat: Network switching strategy adjustment #260
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #260 +/- ##
==========================================
Coverage ? 65.26%
==========================================
Files ? 39
Lines ? 6161
Branches ? 236
==========================================
Hits ? 4021
Misses ? 2137
Partials ? 3 Continue to review full report at Codecov.
|
test link: https://godwoken-bridge-mainnet-7jeqgbmsp-godwoken.vercel.app Please check the following test cases:
cc @Dawn-githup ReferenceGodwoken Public Networks - https://docs.godwoken.io/connectionInfo |
Click the blank area outside the pop-up box to prompt that the pop-up box will also disappear Misclick may occur. I think it should not disappear unless the user closes it or clicks cancel confirm |
regression test case
|
Fixed |
Thanks @GitOfJason |
When I visited https://godwoken-bridge-mainnet-qkjgqqcvp-godwoken.vercel.app/#/v0 , and switch between mainnet_v1 and mainnet_v0, it showed @ShookLyngs @Dawn-githup could you confirm this issue? |
@Flouse I know what the problem is and I will fix it |
@Flouse The network switching part only detects if the network from the provider changes, and our app does not actually need to add mainnet/testnet v0 networks to the provider. Which means users add v1 networks to their providers even if they're using the v0 bridge. However, it does look weird. @GitOfJason How do you plan to fix it? |
Sorry, I understand it wrong. As @ShookLyngs said, in order to make the network name look less strange, we should specify a display name instead of using |
It seems your first attemp was friendly enough, how about using the predefined const networkName = `Godwoken ${isMainnet ? "Mainnet" : "Testnet"}`; |
@Flouse @ShookLyngs I will fix it in this way |
Describe
This pull request optimizes the network switching policy.
When network changes are detected,Not directly switch the network,Instead, the user is notified and asked to switch the network
Related issues