-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: metamask install tips #256
perf: metamask install tips #256
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #256 +/- ##
==========================================
Coverage ? 65.26%
==========================================
Files ? 39
Lines ? 6161
Branches ? 236
==========================================
Hits ? 4021
Misses ? 2137
Partials ? 3 Continue to review full report at Codecov.
|
It's a cool fix to the UI/UX of the app, Thank you for your participation. cc @Flouse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks to @miaosun009
+1 |
I think a better course of action might be |
A simple UI experience optimization
Display installation reminders in the form of modal windows on browsers without Metamask plug-ins to ensure consistent visual style and avoid repeated reminders
before :
2023-02-02.22.56.50.mov
after:
2023-02-02.22.55.48.mov