Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: metamask install tips #256

Merged
merged 2 commits into from
Feb 3, 2023
Merged

perf: metamask install tips #256

merged 2 commits into from
Feb 3, 2023

Conversation

miaosun009
Copy link
Contributor

@miaosun009 miaosun009 commented Feb 2, 2023

A simple UI experience optimization
Display installation reminders in the form of modal windows on browsers without Metamask plug-ins to ensure consistent visual style and avoid repeated reminders

before :

2023-02-02.22.56.50.mov

after:

2023-02-02.22.55.48.mov

@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
godwoken-bridge-mainnet ✅ Ready (Inspect) Visit Preview Feb 2, 2023 at 4:59PM (UTC)
godwoken-bridge-testnet ✅ Ready (Inspect) Visit Preview Feb 2, 2023 at 4:59PM (UTC)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@3200b8d). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #256   +/-   ##
==========================================
  Coverage           ?   65.26%           
==========================================
  Files              ?       39           
  Lines              ?     6161           
  Branches           ?      236           
==========================================
  Hits               ?     4021           
  Misses             ?     2137           
  Partials           ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3200b8d...8e0ab5b. Read the comment docs.

@ShookLyngs
Copy link
Collaborator

It's a cool fix to the UI/UX of the app, Thank you for your participation.
Although placing a modal component in a context component might not be a good idea, I don't really have a quick fix for the problem right not, so I think we can work that later.

cc @Flouse

Copy link
Collaborator

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to @miaosun009

@Flouse
Copy link
Collaborator

Flouse commented Feb 3, 2023

I think we can work that later.

+1

@miaosun009
Copy link
Contributor Author

It's a cool fix to the UI/UX of the app, Thank you for your participation. Although placing a modal component in a context component might not be a good idea, I don't really have a quick fix for the problem right not, so I think we can work that later.

cc @Flouse

I think a better course of action might be
Use the Modal.info method to display the reminder and specify a ClassName consistent with CostomModal

@Flouse Flouse merged commit b80fe36 into godwokenrises:develop Feb 3, 2023
@miaosun009 miaosun009 deleted the perf-metamask-install-tips branch February 3, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants