Feat: update block produce time on v1 networks #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Flouse
approved these changes
Nov 14, 2022
Dawn-githup
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the latest version of Godwoken V1, the withdrawal finality is relatively stable at:
mainnet- 8.75 daystestnet- 13 minsSo I changed the block produce time in our v1 configs to better match the current status.
Also I've added a "~" in the withdrawal confirmation dialog, and when submitting, the dialog shows a rounded time.
For instance, on mainnet_v1 it shows
~9 daysinstead of8.75 days:Related issues:
Thanks to @alejandroRbit for pointing out the issue