Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: unlock legacy withdrawal cells #200

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Feat: unlock legacy withdrawal cells #200

merged 4 commits into from
Oct 26, 2022

Conversation

ShookLyngs
Copy link
Collaborator

@ShookLyngs ShookLyngs commented Sep 28, 2022 •
edited
Loading

Description

Some legacy(v0) withdrawal cells are still locked, and the current version of light-godwoken/godwoken-bridge doesn't provide this feature. This PR provides a unlock function in light-godwoken, and a unlock button in mainnet_v0 of godwoken-bridge.

Changes

  • Feature: Add method/component to unlock legacy(v0) withdrawal cells
  • Feature: Add script to test the unlock feature locally

Checks

Please check the following list before merging the PR:

  • At least unlock an actual legacy withdrawal cell
  • Change the base branch to develop

@vercel
Copy link

vercel bot commented Sep 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
godwoken-bridge-mainnet ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 1:53AM (UTC)
godwoken-bridge-testnet ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 1:53AM (UTC)

@Flouse Flouse requested a review from zeroqn September 29, 2022 02:25
Base automatically changed from fix-ui-stacked-issues to ref-custom-tokens September 29, 2022 09:55
@Flouse Flouse changed the base branch from ref-custom-tokens to develop September 29, 2022 09:57
@ShookLyngs ShookLyngs changed the base branch from develop to ref-custom-tokens September 29, 2022 13:05
@ShookLyngs
Copy link
Collaborator Author

ShookLyngs commented Oct 7, 2022 •
edited
Loading

The current version of unlock feature doesn't work because light-godwoken is using a deprecated version of withdrawal_lock for mainnet_v0. I have fixed it locally and successfully unlocked a few legacy withdrawal cells.

But the UI needs some more tweaking.
So for now I will change status of the PR to draft, and change it back when the UI is also ready.

@ShookLyngs ShookLyngs marked this pull request as draft October 7, 2022 18:17
@ShookLyngs ShookLyngs marked this pull request as ready for review October 8, 2022 09:15
@ShookLyngs
Copy link
Collaborator Author

After some changes to the godwoken-bridge, The PR is now ready for review.

@ShookLyngs ShookLyngs changed the base branch from ref-custom-tokens to develop October 9, 2022 08:33
@ShookLyngs ShookLyngs merged commit 0907447 into develop Oct 26, 2022
@Dawn-githup Dawn-githup mentioned this pull request Oct 27, 2022
Closed
@Flouse Flouse deleted the feat-v0-unlock branch October 28, 2022 08:08
@Flouse Flouse mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@classicalliu classicalliu classicalliu approved these changes

@zeroqn zeroqn zeroqn approved these changes

@Flouse Flouse Awaiting requested review from Flouse

@RetricSu RetricSu Awaiting requested review from RetricSu

Assignees

@ShookLyngs ShookLyngs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShookLyngs @classicalliu @zeroqn