Add FontVariation unit test
#99687
Add FontVariation unit test
#99687
Conversation
There was a problem hiding this comment.
NotoSans_Regular.woff2 is not a variable font, so it's not suitable for testing most of the FontVariation features.
Tests should check something that can be accidentally broken, the main purpose of testing is to catch potential regressions:
- Check results of the complex operations against known good values (for variable font, it can be glyph metrics for different configs).
- Check if input values are sanitized correctly (try using invalid or unusual values).
- Add an example for a complex set of operations (with comments, so it also acts as low-level documentation).
None of the tests in this PR do anything useful, all are either duplicates of existing tests (loading font and checking it is loaded correctly), or essentially are equivalent to:
int a = 1;
CHECK(a == a);
| CHECK(font_file->load_dynamic_font("thirdparty/fonts/NotoSans_Regular.woff2") == OK); | ||
|
|
||
| font_variation->set_base_font(font_file); | ||
| font_variation->get_base_font()->set_name(font_file->get_font_name()); |
There was a problem hiding this comment.
set_base_font sets the base font, but not the name of the base font. So this is just setting the name and aforementioned
int a = 1;
CHECK(a == a);
Ok, does godot have any variable font files in its repo? Or would I need to add one? From what I can see there are no variable fonts in the repo. And for the rest sure I can try to make a more complex example, check glyphs, input values being sanitized etc |
No, I do not think any of the included fonts is variable, but custom resources for test can be added to |
Added unit test cases for
FontVariantThe tests load a dynamic font, sets the base font of the
FontVariant, sets some properties for the variant, and checks that the originalFontFilevalues are not equal to the changedFontVariant. Let me know if I should add/edit anything else.Link back to #43440