-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Projection
#99125
Add tests for Projection
#99125
Conversation
8d3129a
to
ffe5c8b
Compare
980655b
to
d5f4beb
Compare
Sorry for these repeated force push. The workflow stopped on a weird error with asan. I ended up removing the |
d5f4beb
to
9092a3e
Compare
Last force push I hope... Everything builds and runs fine in my environment |
Allright, ready for review ! |
9092a3e
to
b0e91f1
Compare
Rebased on top of #95303 |
b0e91f1
to
64d9b2f
Compare
64d9b2f
to
f1f47c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
This PR adds nearly full test coverage for struct
Projection
.The following few methods are not covered yet and left to further PR(s) :
set_for_hmd()
andcreate_perspective_hmd()
set_perspective()
with eye inputset_orthogonal()
with aspect input andcreate_orthogonal_aspect()
set_frustum()
with aspect input andcreate_frustum_aspect()
get_pixels_per_meter()
get_lod_multiplier()
Transform3D
)