Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_rid_func from GDExtensionClassCreationInfo4 #96787

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Remove get_rid_func from GDExtensionClassCreationInfo4 #96787

merged 1 commit into from
Sep 11, 2024

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Sep 10, 2024 •
edited
Loading

Since _get_rid is now bound as a normal virtual method, the get_rid_func in GDExtensionClassCreationInfo is not needed and would be nice to remove it to prevent confusion.

If we merge this for 4.4, we don't need to make a new GDExtensionClassCreationInfo struct, because GDExtensionClassCreationInfo4 was created in #91018.

@raulsntos raulsntos added this to the 4.4 milestone Sep 10, 2024
@raulsntos raulsntos requested a review from a team as a code owner September 10, 2024 11:52
dsnopek
dsnopek approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a great idea, and the code looks good to me

@Bromeon Bromeon mentioned this pull request Sep 10, 2024
Open
21 tasks
@akien-mga akien-mga merged commit d8e5d61 into godotengine:master Sep 11, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the gdextension/remove-get-rid-func branch September 11, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement topic:gdextension
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @akien-mga @dsnopek