Add metadata for char16_t and char32_t
#95840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Aug 20, 2024
e199375 to
cd9b99e
Compare
|
Thanks! This looks good to me. The CI situation is going to be a little weird. In order to prevent a circular dependency between the CI of Godot and godot-cpp, we run godot-cpp N-1 in the Godot tests. So, maybe we'll need to cherry-pick the change to recognize |
|
Oh, I didn't realize we weren't using the |
We don't seem to expose any API that uses `char16_t` yet, but I added it anyway since we make the type info for it. I didn't add anything for `wchar_t` because we are not making a type info so maybe we don't have a need for it yet, it could be added in the future. To prevent breaking compatibility with the C# bindings, we ignore the `char32_t` metadata and still use `System.Int64`.
cd9b99e to
aaffab8
Compare
dsnopek
approved these changes
Sep 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PtrToArg<char32_t>#95317.We don't seem to expose any API that uses
char16_tyet, but I added it anyway since we make the type info for it.I didn't add anything for
wchar_tbecause we are not making a type info so maybe we don't have a need for it yet, it could be added in the future.To prevent breaking compatibility with the C# bindings, we ignore the
char32_tmetadata and still useSystem.Int64.