Fix center viewport not working horizontally #93792
Merged
+70
−94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrap condition was inverted, so it never moved horizontally.
It's part of
center_viewport_to_caret
but it adjusts the caret horizontally instead of centering it intentionally to match other editors, so searching only moves the horizontal scrollbar if needed.I changed it a bit so that it checks both ends of selected text if it is on one line, so searching for text makes sure it is on screen.
Also added a guard to
adjust_viewport_to_caret
to match.