Add button unit test #93381
Merged
Add button unit test #93381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
Calinou
reviewed
Jun 21, 2024
|
Could you squash your commits? |
Geometror
reviewed
Jul 14, 2024
|
Needs another squash. After that, I think it's ready. |
Geometror
approved these changes
Jul 23, 2024
|
There's been some changes to how tests are run, could you please rebase just to make sure they run correctly still |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of issue #43440
Added a unit test for the is_hovered() method that covers when a button is first initialized, hovered over, and when the mouse exits the button.