Add tests for AnimationPlayer
#92649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and modified test_main.cpp to include the new file
AnimationPlayer
|
Since most of your code is commented out I'd suggest making this a draft until you're done, or remove the commented out code |
tests/test_main.cpp
Outdated
| @@ -100,6 +100,8 @@ | |||
| #include "tests/core/variant/test_variant.h" | |||
| #include "tests/core/variant/test_variant_utility.h" | |||
| #include "tests/scene/test_animation.h" | |||
| #include "tests/scene/test_animation_player.h" | |||
| #include "tests/scene/test_arraymesh.h" | |||
There was a problem hiding this comment.
Suggested change
| #include "tests/scene/test_arraymesh.h" |
Don't move this here it's below to prevent errors
There was a problem hiding this comment.
Didn't see that, it copied it there when I synced with main repo, my bad.
tests/scene/test_animation_player.h
Outdated
| namespace TestAnimationPlayer { | ||
|
|
||
| TEST_CASE("[AnimationPlayer] get & set default_blend_time") { | ||
| AnimationPlayer *animationPlayer = memnew(AnimationPlayer); |
There was a problem hiding this comment.
Suggested change
| AnimationPlayer *animationPlayer = memnew(AnimationPlayer); | |
| AnimationPlayer *animation_player = memnew(AnimationPlayer); |
Please use snake_case, for all
There was a problem hiding this comment.
Got it, correcting and updating now.
AnimationPlayerAnimationPlayer
…mation_player.h and deleted commented code
fire
reviewed
Jun 1, 2024
99 tasks
|
I need to add a test to guard #97760. Should I add my test there, since this thread seems still ongoing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added file test_animation_player.h under tests/scene.
File contains tests cases for methods set_default_blend_time, get_default_blend_time, set_blend_time and get_blend_time.
Modified test_main.cpp to include the new test file.
EDIT: forgot to link to issue #43440 (sorry).