Expose World3D.compositor

[nonchip]

this closes godotengine/godot-proposals#9815

I'm positive this just got missed in the Compositor implementation, since i could find no mention of its omission or any reasons for it (and it only makes using World3D resources more cumbersome).

[AThousandShips]

This will be overridden by the one in the first WorldEnvironment currently:

godot/scene/3d/world_environment.cpp

Lines 98 to 107 in be56cab

	void WorldEnvironment::_update_current_compositor() {
	WorldEnvironment *first = Object::cast_to<WorldEnvironment>(get_tree()->get_first_node_in_group("_world_compositor_" + itos(get_viewport()->find_world_3d()->get_scenario().get_id())));
	if (first) {
	get_viewport()->find_world_3d()->set_compositor(first->compositor);
	} else {
	get_viewport()->find_world_3d()->set_compositor(Ref<Compositor>());
	}
	get_tree()->call_group_flags(SceneTree::GROUP_CALL_DEFERRED, "_world_compositor_" + itos(get_viewport()->find_world_3d()->get_scenario().get_id()), "update_configuration_warnings");
	}

So it doesn't seem to be overlooked IMO

[nonchip]

@AThousandShips that is intended+documented, just like the environment and camera_attributes.

what was overlooked was exposing it in the actual resource where it is provided to the Viewport, thus forcing us to use the builtin WorldEnvironment node to affect that one specific property only.

[AThousandShips]

The documentation should be updated on the World3D then I'd say to clarify this

[nonchip]

@AThousandShips i'm not sure i understand what you mean, i took the documentation of the other properties that work exactly the same way and replaced the names. how should this be documented differently? should maybe all of them be documented a bit more thoroughly? maybe a note in the class doc in general about how WorldEnvironment regularly writes to the World3D?

[AThousandShips]

(You don't need to tag me I'm right here, just adds annoying pings)

It should match the part with "The default ... if not set on Camera3D." of camera_attributes

The rest is out of scope for this but this is a very important thing to note, or people will be confused when the compositor they assigned is suddenly replaced when a camera or WorldEnvironment enters the scene

[nonchip]

the issue there is that the Camera3D logic does actually preserve the default value while tracking the temporary override by "enabled" cameras, while WorldEnvironment just writes all over all of those properties directly. I think I'll add a "this will be overwritten by WorldEnvironment nodes in the world", the "default" implies it stays the default.

[AThousandShips]

I'd say it doesn't imply that and that it should be uniform, so I'd say the documentation should be the same just with Compositor instead

Note that the proposal that proposed this feature only mentioned WorldEnvironment and Camera nodes, not World3D, so I think this was by design:

• Implement a Rendering Compositor godot-proposals#7916