Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle y-billboard option to standard shader #88107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arnklit
Copy link
Contributor

@Arnklit Arnklit commented Feb 8, 2024

This adds a particle y-billboard option to Standard Material.

image

When used with Align Y on the particles it allows you to have particles that align themselves with velocity, but face the camera.

image
image

Note I'm not sure if this should be added since you can also achieve this with the "Particles -> Drawing -> Transform Align -> Z Billboard + Y to Velocity". But these options don't work with stuff like Particle Animation.

In general I'm not sure why there are billboarding settings both in the Particles and in the Material like this.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. This is a great addition to have for VFX like water fountains, sparks and the like 🙂

I've looked at the code and it seems good to me.

Testing project: test_pr_88107.zip

simplescreenrecorder-2024-02-09_12.21.17.mp4

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 9, 2024
@QbieShay
Copy link
Contributor

QbieShay commented Feb 9, 2024

This needs to be discussed in a rendering meeting but we should try to understand where to put bollboarding options for particles. I'm not sure standard material makes sense.

@Calinou
Copy link
Member

Calinou commented Feb 9, 2024

This needs to be discussed in a rendering meeting but we should try to understand where to put bollboarding options for particles. I'm not sure standard material makes sense.

The reason we had Particle Billboard in the material is that it allows for configuring flipbook animation, so if we remove these options, we have to make particle flipbook animation depend on another checkbox within the material.

@QbieShay
Copy link
Contributor

More context: godotengine/godot-proposals#8367

@akien-mga akien-mga modified the milestones: 4.3, 4.x May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Preserve Orientation billboard property
5 participants