GDScript: Add unsafe_assignment
warning
#83697
Open
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
unsafe_assignment
warning, which optionally can be enabled to warn the user if they are implicitly assigning a value of unknown type to a variable without casting it.NOTE: This warning conflicts with the existing
unsafe_cast
warning, and this PR should include discussion on whether we prefer warning for unsafe casting or for unsafe assignment.Examples of both warnings:
CC @dalexeev since we were talking about a separate discussion of pattern matching and the topic of unsafe casting was brought up and whether unsafe assignment should be a warning.