Fix monitoring status of Area2D and doing same logic on Area too

[volzhs]

Fix #8090

5b556ca makes monitoring always true when NOTIFICATION_ENTER_TREE
This PR fix regression but not to touch what 5b556ca tried to fix.

[reduz]

Nice, think you could check Area also? (it uses the same logic for 3D)

…

On Mon, Apr 3, 2017 at 9:05 AM, volzhs ***@***.***> wrote: Fix #8090 <#8090> 5b556ca <5b556ca> makes monitoring always true when NOTIFICATION_ENTER_TREE This PR fix regression but not to touch what 5b556ca <5b556ca> tried to fix. ------------------------------ You can view, comment on, or merge this pull request online at: #8242 Commit Summary - Fix monitoring status of Area2D File Changes - *M* scene/2d/area_2d.cpp <https://github.com/godotengine/godot/pull/8242/files#diff-0> (11) - *M* scene/2d/area_2d.h <https://github.com/godotengine/godot/pull/8242/files#diff-1> (1) Patch Links: - https://github.com/godotengine/godot/pull/8242.patch - https://github.com/godotengine/godot/pull/8242.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8242>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z2xsRZT1oYtrjbw2D6Tj2mdcOXZoXks5rsOB7gaJpZM4MxcjZ> .

[volzhs]

@reduz @akien-mga
Note that master branch or Area(3D) doesn't have 5b556ca commit. hm...
should we add same codes with 5b556ca on Area(3D) and master also?

[akien-mga]

It seemed in #7508 that the fix was not necessary for the master branch, only the first part of it was merged. But @LoneSurvivor would likely know better than I do :)

[volzhs]

@akien-mga what about Area(3D) on 2.1 branch?
#7508 fixed only Area2D but Area(3D) has same logic as @reduz said.

[akien-mga]

I suppose a similar fix should be done for Area, though I'm not sure, I haven't really tried to reproduce the issue @LoneSurvivor was trying to address.

[RandomShaper]

Please note this is a breaking change!

I've builr with the latest sources and while running my game I've noticed my characters were not reacting. After some research, I've found this PR.

Not sure it it has something to do with this, but monitoring is setup as not to be stored if set to true.

UPDATE: monitoring is defined with ADD_PROPERTYNO which in turn sets PROPERTY_USAGE_STORE_IF_NONONE for it.

[RandomShaper]

Well, I'm a bit puzzled here. Probably the original issue had something to do with #7978.

Hopefully, the current code shows the correct behavior. I'll enable monitoring on my Area2Ds and check from now on if everything works well.