Don't paste nodes as sibling of scene root #81673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanabx
approved these changes
Sep 15, 2023
It's Godot 2 theme (one of the default presets) with accent color shifted to red. |
|
I reworked the PR to disable the option instead of defaulting to paste as child: |
YuriSizov
reviewed
Sep 15, 2023
YuriSizov
approved these changes
Sep 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Paste As Sibling option could be used without selection, resulting in node being a sibling of viewport.
godot_spbCrcPPis.mp4
This PR fixes that. Also fixes wrong node name in the action.
Another thing I noticed is that when pasting as sibling the new node will be always at the end of the list. I think it should be just below the used sibling.
EDIT:
Also fixes the menu option not working correctly.