GDExtension: Remove DLL copy if it fails to load #80720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 17, 2023
|
It probably makes sense to add your description as a comment in the code, so that it's clear when reading later 🙂 |
|
What comment text would you suggest? I can't seem to come with something that doesn't seem redundant in context. I feel like it's pretty clear what's going on when you can see the ~5-15 lines that come before this:
|
|
Maybe based on:
We could simply have something like: // If the DLL fails to load, make sure that temporary DLL copies are cleaned up. |
141a2fa to
908b8c0
Compare
|
Ok, thanks, I've added the comment |
Bromeon
approved these changes
Aug 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #80188
That PR causes the Godot editor (on Windows) to make a copy of the GDExtension's DLL in order to prevent Windows from locking the original DLL, so the developer can re-compile it without having to stop the editor first. When the editor is shutdown, any DLL copies for loaded GDExtensions will get cleaned up.
But, currently, if the DLL fails to load, the copy won't get cleaned up. I've been testing this by compiling a GDExtension with
scons use_mingw=yes use_static_cpp=nowhich will fail to load because it can't find the C++ runtime libraries.Anyway, with this PR, it will clean up the DLL if it fails to load!