Fix corner radius not scaling with theme scale in the default theme #79640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also uses rounding consistently for scale multipliers, so that behavior is more predictable with non-integer scale factors like `1.25` and `1.5`.
adamscott
approved these changes
Jul 19, 2023
YuriSizov
approved these changes
Jul 21, 2023
|
Thanks! |
|
For consistency I'd skip it from cherry-picking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also uses rounding consistently for scale multipliers, so that behavior is more predictable with non-integer scale factors like
1.25and1.5.The default theme's appearance is not affected at its default scale of
1.0, including when using thecanvas_itemsstretch mode.Testing project: https://github.com/godotengine/godot-demo-projects/tree/master/gui/control_gallery
Preview
Click to view at full size. Default Theme Scale is set to
3.0on those screenshots.For comparison, this is the UI when using the
canvas_itemsstretch mode and scaling up to 4K from 1152×648: