Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance icon fallback and their docs for exporters #77821

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Enhance icon fallback and their docs for exporters #77821

merged 1 commit into from
Jun 5, 2023
+45 −32

Conversation

YeldhamDev
Copy link
Member

  • Make Windows exporter fallback to other alternatives (first application/config/windows_native_icon then application/config/icon) if no icon was set.
  • Make macOS exporter fallback to application/config/macos_native_icon first, and then application/config/icon.
  • Improve exporter doc pages with references and better wording.

@YeldhamDev YeldhamDev added this to the 4.x milestone Jun 3, 2023
@YeldhamDev YeldhamDev requested review from a team as code owners June 3, 2023 22:39
akien-mga
akien-mga approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit d0dfc01 into godotengine:master Jun 5, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.1 Jun 5, 2023
@YeldhamDev YeldhamDev deleted the fallback!_fallback!_fallback! branch June 5, 2023 12:43
@YeldhamDev YeldhamDev mentioned this pull request Jul 5, 2023
Closed
@Draradech Draradech mentioned this pull request Jan 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:export
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @akien-mga @bruvzg