Add a get_node_index method to GLTFState
#77534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35ba35c to
b3446e9
Compare
fire
approved these changes
May 27, 2023
fire
reviewed
May 27, 2023
YuriSizov
reviewed
May 27, 2023
YuriSizov
reviewed
May 27, 2023
YuriSizov
reviewed
May 27, 2023
b3446e9 to
e1a0d7f
Compare
YuriSizov
reviewed
May 27, 2023
YuriSizov
reviewed
May 27, 2023
e1a0d7f to
5e139c2
Compare
YuriSizov
approved these changes
May 27, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on GLTFDocumentExtension classes in GDScript, I have already encountered 2 places where this method would be useful during the export process, so I think it's time to add it to Godot. Technically it's not vital, previously I was implementing it on top of
get_scene_node, but this PR is faster and cleaner. And yes I tested it.