Use angle_rand to calculate base_angle in particles process material
#75999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 13, 2023
2669d21 to
821917b
Compare
|
Updated to fix the base |
akien-mga
approved these changes
Apr 13, 2023
|
Thanks! |
|
Sweet! I gotta test this in 4.0.3 :) |
|
Cherry-picked for 4.0.3. |
angle_rand to calculate base_angle in particles process material
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49767
Using
angle_randfor the random value ensures that the returnedbase_angleis the same in thestart()function and in theprocess()function.I also changed the base
tex_angleto 1.0 to match theprocess()function. Without this change the base_angle was always 0 in thestart()function which could lead to a different kind of snapping on the first frame.