Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the icons in AnimationTrackEditor / BoneMapEditor store correctly #71365

Closed
wants to merge 1 commit into from
Closed

Make the icons in AnimationTrackEditor / BoneMapEditor store correctly #71365

wants to merge 1 commit into from

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jan 13, 2023 •
edited
Loading

The same fixes pointed out in #71321 (review) were applied to AnimationTrackEditor. Also, the BoneMapEditor icons are now stored correctly.

@TokageItLab TokageItLab added this to the 4.0 milestone Jan 13, 2023
@TokageItLab TokageItLab requested review from YuriSizov and a team January 13, 2023 22:51
@TokageItLab TokageItLab force-pushed the animtrackedit-loopicon-fetch branch from c1a2305 to c7fa9e4 Compare January 30, 2023 14:41
@akien-mga
Copy link
Member

I believe this should make use of the theme_cache structs @YuriSizov defined in various editor plugins. You can check e.g. editor/plugins/mesh_editor_plugin.h for an example of how it's defined and used.

@TokageItLab TokageItLab modified the milestones: 4.0, 4.x Feb 8, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 Apr 4, 2023
@TokageItLab @YuriSizov
Make the icons in AnimationTrack/BoneMapEditor store correctly
ab8fa22 
Co-authored-by: Yuri Sizov <yuris@humnom.net>
@YuriSizov YuriSizov force-pushed the animtrackedit-loopicon-fetch branch from c7fa9e4 to ab8fa22 Compare April 4, 2023 17:49
@YuriSizov
Copy link
Contributor

@TokageItLab I made the changes to use the theme cache and pushed to your branch. The bone mapper required extra work, since it already had a few classes that could benefit from this even before this PR, and because it didn't actually try to update the icons when the theme changed.

All code should be good now, but I don't have any project handy to test if it all works fine. Can you please double-check?

@YuriSizov
Copy link
Contributor

Bump

@TokageItLab
Copy link
Member Author

TokageItLab commented Apr 11, 2023 •
edited
Loading

@YuriSizov I took a quick look and it seems that the current commit is causing freeze in BoneMapEditor, so I will investigate again later.

@TokageItLab TokageItLab marked this pull request as draft April 11, 2023 11:47
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@TokageItLab
Copy link
Member Author

It is probably out of date. I think others have solved some of the problems.

@TokageItLab TokageItLab removed this from the 4.2 milestone Sep 26, 2023
@TokageItLab TokageItLab deleted the animtrackedit-loopicon-fetch branch February 14, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov Awaiting requested review from YuriSizov

Assignees
No one assigned
Labels
archived bug topic:animation topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TokageItLab @akien-mga @YuriSizov