Unbind Variant methods that change immutable types. #70995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can add a comment like "Do not bind rotation, scale, skew, ..." and remove the dead code. But shouldn't we outright remove those methods in C++ too? That would be much cleaner. |
2a3376f to
89e74f1
Compare
|
@akien-mga Those are useful in C++ for performance, but in script since types are immutable they can't really be exposed. |
Fixes godotengine#62706. Code is commented instead of removed to clarify why they should not be re-added.
89e74f1 to
576ae69
Compare
|
@akien-mga done |
akien-mga
approved these changes
Jan 6, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62706.
Code is commented instead of removed to clarify why they should not be re-added.