Add tests for FastNoiseLite/NoiseTexture #70919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a test suite for the noise module while fixing some minor bugs (primarily with seamless noise generation).
Detailed changes:
FastNoiseLite
andNoiseTexture2D
test_utils.h
ortest_macros.h
(and generalized), but because they are currently just needed by these tests I left them intest_fastnoise_lite.h
NoiseTexture._generate_texture
crashes Godot #61044There are still some small structural quirks in the noise module (e.g. the private method _generate_texture shouldn't be exposed and rather replaced with another solution, because right know it just returns the generated image without setting it internally so it is generated twice). But that's for another PR.