Fix "Go to definition" for GDScript type hints #69473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
reviewed
Dec 2, 2022
6775f72 to
5acf0e1
Compare
|
Building issue should be fixed |
kleonc
reviewed
Dec 3, 2022
5acf0e1 to
4b74aac
Compare
|
@vnen What do you think of that PR? It seems fine to me. |
4b74aac to
0803467
Compare
|
I pushed a rebase to get it to re-run CI checks, as the last build was more than 6 months ago. Also tweaked the commit message for clarity. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to fix issue #68475
Here is the project that I used to test my changes
example.zip
Production edit: Fixes #68475