Fix scene reload crash related to mouse cursor update #69318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e2ecac to
f020198
Compare
This was referenced Jan 16, 2023
|
This was discussed in a PR-review-meeting. |
After a scene reload a mouse cursor updates is performed via a InputEventMouseMotion, that is exposed to the user. The state of Input is however not adjusted to this InputEventMouseMotion which can lead to inconsistencies. This PR makes sure, that it is not exposed to the user. It utilizes the method of Viewport::_process_picking for marking events that are not sent to the user, so that this function doesn't need to be changed.
f020198 to
5bb66d3
Compare
KoBeWi
approved these changes
Apr 18, 2023
RandomShaper
approved these changes
Apr 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a scene reload, a mouse cursor update is performed via a
InputEventMouseMotion, that is exposed to the user. The state ofInputis however not adjusted to thisInputEventMouseMotionwhich can lead to inconsistencies:Inputresolve #69227
Bugsquad edit: Fixes #71500
introduced in #58995
This PR makes sure, that the event is not exposed to the user. It makes sense, that events for internal concerns should not be exposed to the user.
It utilizes the same method that was already used in
Viewport::_process_pickingfor marking events that are not sent to the user, so that this function doesn't need to be changed.Updated 2023-02-10: Fix merge conflict