Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing String & StringName operator descriptions #68217

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Nov 3, 2022

Related to #68838.

Adds missing descriptions to the String and StringName operators in the Class Reference. Most notably, a decently detailed one to the "%" operator pointing to the String formatting tutorial.

Also corrects String.bigram()'s print value because I glanced at it, it technically was outdated.

@Mickeon Mickeon requested a review from a team as a code owner November 3, 2022 16:39
@Calinou Calinou added this to the 4.0 milestone Nov 3, 2022
doc/classes/String.xml Outdated Show resolved Hide resolved
@Mickeon
Copy link
Contributor Author

Mickeon commented Nov 20, 2022

Updated PR to correctly mention Unicode order over alphabetical order in the comparison operators.

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure if the link to Wikipedia is sufficient to explain the order, as it doesn't directly answer that question. But I don't have an alternative to suggest.

doc/classes/String.xml Outdated Show resolved Hide resolved
doc/classes/String.xml Outdated Show resolved Hide resolved
@Mickeon
Copy link
Contributor Author

Mickeon commented Nov 23, 2022

I'm also not sure if the link to Wikipedia is sufficient to explain the order,

Do note that the link has been fetched from above, in casecmp_to and its other variations. I agree it'd be nice to find a better website for it, though.

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mhilbrunner
Copy link
Member

Looks good to me now, thanks!

@mhilbrunner mhilbrunner merged commit f05a55e into godotengine:master Nov 23, 2022
@Mickeon Mickeon deleted the doc-stringmngffh branch November 23, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants