Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with Vulkan disabled and no Vulkan headers installed. #67879

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix build with Vulkan disabled and no Vulkan headers installed. #67879

merged 1 commit into from
Oct 31, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 25, 2022

No description provided.

@bruvzg bruvzg added this to the 4.0 milestone Oct 25, 2022
@bruvzg bruvzg requested review from a team as code owners October 25, 2022 19:22
@bruvzg bruvzg force-pushed the fix_no_vlk branch 2 times, most recently from cbb8ea1 to b2391be Compare October 25, 2022 19:43
@bruvzg bruvzg requested a review from a team as a code owner October 25, 2022 19:43
@m4gr3d
Copy link
Contributor

m4gr3d commented Oct 25, 2022

@bruvzg With this change, we should lower the minimum Android api used when building Godot 4.0. See #67610

@bruvzg
Copy link
Member Author

bruvzg commented Oct 26, 2022

With this change, we should lower the minimum Android api used when building Godot 4.0. See #67610

Min. versions probably should be determined based on build flags, but at least for iOS and macOS it's set in a Xcode project and .app template in addition to the scons. So we probably will need some automation for the export template zip assembly added to update these parts as well (or set it during export).

Also, we should bump min. versions for Vulkan enabled builds for iOS and macOS to 13.0 and 10.15.

@akien-mga akien-mga merged commit 9188bc7 into godotengine:master Oct 31, 2022
@akien-mga
Copy link
Member

Thanks!

@FeralBytes
Copy link
Contributor

Did this one make it to Beta4 or will it be in the next beta? Thank you for your time.

@Riteo
Copy link
Contributor

Riteo commented Nov 7, 2022

@FeralBytes these are the commits between beta3 and beta4.

It looks like it is indeed in beta4.

@bruvzg bruvzg deleted the fix_no_vlk branch November 21, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android platform:ios platform:linuxbsd platform:macos platform:windows topic:buildsystem
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bruvzg @m4gr3d @akien-mga @FeralBytes @Riteo