Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console wrapper app to handle console i/o redirection on Windows. #67434

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 15, 2022

When building Godot in GUI mode, generates an extra console wrapper executable which:

  • Wait until all child processes are terminated.
  • Lock console to prevent shell from mixing output from the main app with its own.
  • Correctly passes stdin input to the Godot processes.

Supersede #63569

TODO:

@bruvzg bruvzg added this to the 4.x milestone Oct 15, 2022
@bruvzg bruvzg force-pushed the win_wrapper branch 4 times, most recently from 8a18216 to c4845a1 Compare October 17, 2022 08:19
@bruvzg bruvzg changed the title [WIP] Add console wrapper app to handle console i/o redirection on Windows. Add console wrapper app to handle console i/o redirection on Windows. Oct 17, 2022
@bruvzg bruvzg closed this Oct 17, 2022
@bruvzg bruvzg deleted the win_wrapper branch October 17, 2022 12:55
@bruvzg bruvzg restored the win_wrapper branch October 17, 2022 12:55
@bruvzg bruvzg reopened this Oct 17, 2022
@bruvzg bruvzg force-pushed the win_wrapper branch 2 times, most recently from 1993231 to 7366f9e Compare October 24, 2022 05:05
@bruvzg bruvzg marked this pull request as ready for review October 24, 2022 05:21
@bruvzg bruvzg requested review from a team as code owners October 24, 2022 05:21
@akien-mga akien-mga merged commit 191c8ed into godotengine:master Nov 4, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the win_wrapper branch November 15, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants