Implement unit tests for Camera3D #67170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f75f224 to
3bacdf4
Compare
|
@JFonS Are you able to give some insight on the frustum node and how it relates? |
3bacdf4 to
b82241c
Compare
b82241c to
b22d190
Compare
|
I've rebased this PR to use |
|
@JFonS Sorry to bump, but would you mind taking a look at this when you have time? |
b22d190 to
9330fe9
Compare
This commit adds unit tests for Camera3D. Methods tested are: - is_position_behind - is_position_in_frustum - project_position - unproject_position A placeholder size variable is also added here to DisplayServerHeadless in order to make it possible to project points in headless mode.
9330fe9 to
808bbfd
Compare
|
Rebased on current |
|
Superseded by #84826 (which includes tests for all methods included in this PR). Thanks for the contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
Camera3D. Methods tested are:is_position_behindis_position_in_frustumproject_positionunproject_positionThe projection test is currently failing with
Frustumprojection mode. I don't really know how that mode works, to be honest, so any input would be appreciated.A placeholder size variable is also added here to
DisplayServerHeadlessin order to make it possible to project points in headless mode. I'm not sure if this will have any unintended consequences, so I would appreciate feedback from aDisplayServerexpert. If not, it could be helpful for godotengine/godot-proposals#1760.I noticed a fair bit of code duplication between
project_position,project_ray_origin, andproject_local_ray_normalwhile working on this. I think they can probably be refactored to all forward calls to a single function, but I thought that was better left for another PR.Part of #43440.