QuickOpen: Disable loading resources for now, too slow #66215
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As expected while reviewing godotengine#62417 this is indeed not practical without a better system to retrieve this information. Fixes godotengine#66179.
|
Yes it works fine. QO, QO script, and QO scene all open instantly with no console errors on my project. Thanks. |
reduz
added a commit
to reduz/godot
that referenced
this pull request
Jan 21, 2023
* Works for binary and text files. * Makes EditorQuickOpen work with custom resources again. * Information is cached and easily accessible. Properly fixes godotengine#66179. Supersedes godotengine#66215 and supersedes godotengine#62417 **WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
Streq
pushed a commit
to Streq/godot
that referenced
this pull request
Feb 9, 2023
* Works for binary and text files. * Makes EditorQuickOpen work with custom resources again. * Information is cached and easily accessible. Properly fixes godotengine#66179. Supersedes godotengine#66215 and supersedes godotengine#62417 **WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As expected while reviewing #62417 this is indeed not practical without a better system to retrieve this information.
Fixes #66179.
Please confirm that it solves the issue, didn't test.