Fix Signal parameters' type will now be correctly displayed in the node signal preview box.

[Life4gal]

Version of Godot based on:
v4.0.alpha.custom_build [20d6672]

Fixes #65809

Signal parameters' type will now be correctly displayed in the node signal preview box.

Modifications to note:

// modules/gdscript/gdscript_parser.cpp
GDScriptParser::parse_signal();

// modules/gdscript/language_server/gdscript_extend_parser.cpp
ExtendGDScriptParser::parse_class_symbol(const GDScriptParser::ClassNode *p_class, lsp::DocumentSymbol &r_symbol);

// modules/gdscript/gdscript.cpp
GDScript::_update_exports(bool *r_err, bool p_recursive_call, PlaceHolderScriptInstance *p_instance_to_update);

Important note: Compatible with 4.x version only.

Preview:

If you have questions about non-built-in type errors, please see the modification of modules/gdscript/gdscript_parser.cpp

[Chaosus]

Commits need to be squashed to a single one as required by our pipeline (see docs.godotengine.org/en/latest/community/contributing/pr_workflow.html

[Chaosus]

[fix-issue-65809-for-4.x]

Please amend the commit name - and rename it to the PR name ("Fix Signal parameters' type will now be correctly displayed in the node signal preview box.") - we don't use names like "fix [issue link]"

[Life4gal]

I'm sorry about force-pushed, but due to some previous oversights (forgetting git config), some information that did not belong to me was leaked.
So I used rebase and push -f to get this PR(and commit) updated. :)

[YuriSizov]

If your goal is to only fix the display in the docks, then this is an overkill. If the typing information is not available to the dock, or is unreliable, we can hide vars or just let them be, as that is still a valid notation. Since the GDScript engine is not doing type validation, any variant type is actually acceptable.

But if you want to actually implement typing support for signals, then this needs to cover all use cases. Namely, Node is a valid type, it's also a built-in type that should be supported. We still have issues supporting custom user-defined types, but this being worked on.

Either way, this is not in scope for Godot 4.0 as GDScript features are no longer accepted (or any enhancements for that matter) and the work should focus on stability and optimization instead. Also, there is already a proposal for this godotengine/godot-proposals#2557 which you might want to consider for your implementation.

[Life4gal]

If your goal is to only fix the display in the docks, then this is an overkill. If the typing information is not available to the dock, or is unreliable, we can hide vars or just let them be, as that is still a valid notation. Since the GDScript engine is not doing type validation, any variant type is actually acceptable.

But if you want to actually implement typing support for signals, then this needs to cover all use cases. Namely, Node is a valid type, it's also a built-in type that should be supported. We still have issues supporting custom user-defined types, but this being worked on.

Either way, this is not in scope for Godot 4.0 as GDScript features are no longer accepted (or any enhancements for that matter) and the work should focus on stability and optimization instead. Also, there is already a proposal for this godotengine/godot-proposals#2557 which you might want to consider for your implementation.

See this 😄

[Life4gal]

😄😄😄

[Life4gal]

😄😄😄

It looks like signal_name.emit(args...) needs some extra work.

[Life4gal]

😄😄

[adamscott]

CC @vnen

[KoBeWi]

The linked issue has been resolved. Is any part of this PR still relevant?

[adamscott]

The linked issue has been resolved. Is any part of this PR still relevant?

It seems that this PR detects when a connected signal signature is incompatible with the connected function.

[KoBeWi]

Needs rebase then.