Rename uniform to parameter across the engine

[Chaosus]

Changes:

• ShaderMaterial::set_shader_uniform/get_shader_uniform renamed to set_shader_param/get_shader_param.
• All other visual shader classes <Type>Uniform renamed to <Type>Parameter.
• Other uniform methods, parameter and variables renamed to parameters in the VisualShaderEditor.
• Separates VisualShaderNodeTextureUniform to VisualShaderNodeTextureParameter and VisualShaderNodeTexture2DParameter.
• Changed default_value type in VisualShaderNodeVec4Parameter from Quaternion to Vector4.
• Added compatibility classes and changed docs accordingly.

Target to close godotengine/godot-proposals#5123 hope I did everything correct (as far as I remember the last bikeshedding meeting)

[QbieShay]

Hey @Chaosus, thanks a lot for taking the time to do this!
I have two questions:

1. Is the entry for "global shader unifrom" in project setting also changed?
2. I am not sure if they preferred set_shader_param or set_shader_parameter? (@akien-mga ?)
   The rest looks good to me! (Note I didn't test, i can't this weekend)

[Chaosus]

Is the entry for "global shader unifrom" in project setting also changed?

In the project setting, it's called Shader Globals - how do you want to change it?

Also, I didn't change the name of the methods in the RenderingServer and MaterialStorage - I'm not sure that it is a good thing to do, and @reduz would certainly against it.

[clayjohn]

Also, I didn't change the name of the methods in the RenderingServer and MaterialStorage - I'm not sure that it is a good thing to do, and @reduz would certainly against it.

I think anything exposed to users should use "parameter". I don't think it is a big deal to change the naming in RenderingServer and MaterialStorage. After all, reduz originally named them with parameter and it was just changed to "uniform" recently (in #59840 and #59844)

[Zireael07]

I think anything exposed to users should use "parameter".

Yep, should be consistent whichever way the cookie crumbles

[Chaosus]

@clayjohn Alright, I've renamed uniform term to parameter across all functions and enumeration members:

[nathanfranke]

If anyone disagrees with the naming in #64092, let me know. I decided shader_param/ for compatibility/simplicity, and since the internal properties are not user facing (users should really be using set_shader_param("foo", bar))

Edit: Changed to shader_parameter/

[Chaosus]

I've added set_shader_param -> set_shader_parameter to the project converter. Also renamed bunch of parameter names and other internal functions. I leave only some internal classes untouched such as RD::Uniform, UniformSet etc - do I need to rename them too?

[QbieShay]

In the project setting, it's called Shader Globals - how do you want to change it?

Awesome! Shader Globals works perfect.

[clayjohn]

I've added set_shader_param -> set_shader_parameter to the project converter. Also renamed bunch of parameter names and other internal functions. I leave only some internal classes untouched such as RD::Uniform, UniformSet etc - do I need to rename them too?

No, RD::Uniform and Uniform set etc. should all remain as is. Just the user-facing functions to set a single uniform should be changed. I'll review now!

[clayjohn]

Looks mostly good. Great work! I think everything in RenderingDevice should continue to use "uniform". So you'll have to undo those changes unfortunately. I think it is best it maintains the original name as people using it will be more familiar with uniforms as uniform has a specific meaning in the context of graphics APIs that is incompatible with the more general term "parameter". Parameter is fine for the Godot-shader API though, so it is suitable for user-facing code in the editer, scene nodes and RenderingServer

[Chaosus]

@clayjohn Done I think - check again

[reduz]

The actual problem is that uniform term is unfriendly to VisualShader for artists, everywhere else it should be uniform, which is the right term. "parameter" is not more friendly for programmers, its more confusing because anything can be a parameter.

[reduz]

It also marks vulkan_core.h as changed, it should not be?

[Chaosus]

It also marks vulkan_core.h as changed, it should not be?

Sorry, due to formatting suddenly, reverted it back

[akien-mga]

Thanks!