C#: Use custom project setting for C# project files name #64460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting is initially assigned the name of the Godot project, but it's kept freezed to prevent issues when renaming the Godot project. The user can always rename the C# project and solution manually and change the setting to the new name. Co-authored-by: Ignacio Roldán Etcheverry <ignalfonsore@gmail.com>
This doesn't need to wait for that one to be merged. |
neikeq
approved these changes
Aug 17, 2022
|
Fair enough, but we usually want changes to be merged in master first and I wasn't sure if that code may change before it gets merged. |
|
Cherry-picked for 3.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports 9c69862 to 3.x
Fixes #27030
An important difference from the
masterversion is I renamed the settings to be more consistent with how we name C# settings in 3.x:dotnet/project/assembly_name→mono/project/assembly_namedotnet/project/solution_directory→mono/project/solution_directorydotnet/project/c#_project_directory→mono/project/c#_project_directoryCreated as a draft since this is not in master yet (pending the merge of the
dotnet6branch).