-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Invalid RID Error Messages #64234
Conversation
What do these error messages look like out of interest? I'm just wondering if we go to the length of writing the server type in the message, maybe it makes sense to disambiguate e.g. BulletPhysicsServer from GodotPhysicsServer, etc. I suspect the error message currently does show the source file in the Godot IDE, but imo if we are going to show this info in the error message itself, it is kind of strange to not show as much as possible. So I would be tempted to either go with "Invalid RID" and "RID not found" and rely on the file / function info, or write the whole caboodle in the message. 🤔 |
It already shows bullet, sw, 2D, etc in the code line.
Remember users, who only know about physics server and visual server, and not the individual types will also see these messages. I can change it to whatever is directed. |
OK, agree. I'm also wondering whether "attempted to free a NULL RID" might be more informative. 🤔 Although the c++ code uses "valid", it's kind of vague term, it could mean corrupt or outdated or anything. Whereas this is specifically for a RID that has not been allocated, or has been set to NULL. |
OK, I'll change it to null. |
76cd527
to
d7ba3b7
Compare
The messages have been updated with NULL RID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Sorry for delay was away for weekend.
Thanks! |
Differentiates error messages between null, invalid RIDs and those that are not found when calling the
free()
functions in Visual, Physics, and Navigation Servers.Addresses @lawnjelly 's comments:
#55764 (comment)
and
#64199 (comment)
@akien-mga