VCS: Fix wrong number of args passed into _refresh_commit_list #62862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this change also needed in |
|
@Calinou Master needs some extra changes to bring over the plugin to GDExtension. The ideal for the master branch will be to port the plugin to GDExtension and also implement this proposal. I have a draft PR for the port here This change however is only relevant for 3.x because the VCS plugins don't work in master right now, and the VCS plugins will work differently in master anyway when they are finally ported to GDExtension. |
akien-mga
approved these changes
Jul 18, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62859
This makes the commit list work when the user clicks the "Detect New Changes" button, otherwise, it is just throwing a
Method expected 1 arguments, but called with 0.error in the console