Move "Create Debug Tangents" on MeshInstance3D into an editor plugin #62188
Conversation
|
Oops I should've ran the format myself, my bad it's kinda late here, added a git-hook so it won't happen again |
19f95d1 to
b089a8a
Compare
|
Third attempt! Now compiles with tools=off |
|
This moves "Create Debug Tangents" from the manage object properties menu in the inspector(godot 3 screenshot) |
| @@ -383,13 +383,13 @@ void MeshInstance3D::_mesh_changed() { | |||
| update_gizmos(); | |||
| } | |||
|
|
|||
| void MeshInstance3D::create_debug_tangents() { | |||
| MeshInstance3D *MeshInstance3D::create_debug_tangents_node() { | |||
There was a problem hiding this comment.
I would suggest making create_debug_tangents return the mesh instance it creates and adds as a child, but I think that would require me to open a GIP
|
Needs squash and rebase btw. |
4606cc9 to
cb3f284
Compare
Instead of exporting the "create_debug_tangents" function via METHOD_FLAG_EDITOR it gets executed by an editor plugin. This moves it from the "Manage object properties" menu into a mesh menu. It also adds undo/redo functionality to the create debug tangents option.
| } | ||
|
|
||
| add_child(mi, true); | ||
| if (is_inside_tree() && this == get_tree()->get_edited_scene_root()) { |
There was a problem hiding this comment.
This was previously wrapped in #ifdef TOOLS_ENABLED, but I think it's fine to leave it, because get_edited_scene_root() just returns null in non-editor builds.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Thanks for your patience with me ^^ @KoBeWi |
This closes #50158