Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing mipmap LOD bias when FSR 1.0 scaling is not used #61953

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Allow changing mipmap LOD bias when FSR 1.0 scaling is not used #61953

merged 1 commit into from
Jul 28, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 11, 2022 •
edited
Loading

Related to #47401. This reworks the mipmap bias property originally added in #51679.

Mipmap LOD bias can be useful to improve the appearance of distant textures without increasing anisotropic filtering (or in situations where anisotropic filtering is not effective).

fsr_mipmap_bias was renamed to texture_mipmap_bias accordingly. The property hint now allows for greater precision as well.

@Calinou Calinou requested review from a team as code owners June 11, 2022 23:51
@Calinou Calinou force-pushed the mipmap-bias-allow-without-fsr branch from d7c9c17 to dd59632 Compare June 11, 2022 23:59
@Calinou Calinou added this to the 4.0 milestone Jun 11, 2022
@Calinou Calinou mentioned this pull request Jun 12, 2022
Closed
@Calinou Calinou force-pushed the mipmap-bias-allow-without-fsr branch from dd59632 to 827aae2 Compare June 12, 2022 00:47
clayjohn
clayjohn requested changes Jun 12, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks great! I left a few comments on the documentation

doc/classes/Viewport.xml Outdated Show resolved Hide resolved
doc/classes/Viewport.xml Outdated Show resolved Hide resolved
doc/classes/RenderingServer.xml Outdated Show resolved Hide resolved
doc/classes/Viewport.xml Outdated Show resolved Hide resolved
doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the mipmap-bias-allow-without-fsr branch 2 times, most recently from a97f9d9 to 33396f9 Compare June 13, 2022 12:27
@Calinou Calinou mentioned this pull request Jun 16, 2022
Closed
@Calinou Calinou force-pushed the mipmap-bias-allow-without-fsr branch 2 times, most recently from e609408 to 5ad9367 Compare July 9, 2022 23:12
@Calinou Calinou requested a review from a team as a code owner July 9, 2022 23:12
@Calinou Calinou mentioned this pull request Jul 10, 2022
Merged
@akien-mga
Copy link
Member

Needs rebase.

@Calinou
Allow changing mipmap LOD bias when FSR 1.0 scaling is not used
e24029e 
Mipmap LOD bias can be useful to improve the appearance of distant
textures without increasing anisotropic filtering (or in situations
where anisotropic filtering is not effective).

`fsr_mipmap_bias` was renamed to `texture_mipmap_bias` accordingly.
The property hint now allows for greater precision as well.
@Calinou Calinou force-pushed the mipmap-bias-allow-without-fsr branch from 5ad9367 to e24029e Compare July 28, 2022 15:51
@akien-mga akien-mga merged commit 80ceab2 into godotengine:master Jul 28, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the mipmap-bias-allow-without-fsr branch July 28, 2022 17:20
@Calinou Calinou mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:rendering topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @clayjohn