-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Warning to NavigationMesh bake when source geometry is suspiciously big #60945
Merged
akien-mga
merged 1 commit into
godotengine:master
from
smix8:navmesh_bake_size_warning_4.x
May 11, 2022
Merged
Add Warning to NavigationMesh bake when source geometry is suspiciously big #60945
akien-mga
merged 1 commit into
godotengine:master
from
smix8:navmesh_bake_size_warning_4.x
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
navmesh_bake_size_warning_4.x
branch
from
May 11, 2022 13:56
530fe3a
to
736fd9a
Compare
akien-mga
reviewed
May 11, 2022
akien-mga
reviewed
May 11, 2022
akien-mga
added
the
cherrypick:3.x
Considered for cherry-picking into a future 3.x release
label
May 11, 2022
CC @Scony |
smix8
force-pushed
the
navmesh_bake_size_warning_4.x
branch
from
May 11, 2022 14:12
198c22b
to
4baf9dc
Compare
Scony
approved these changes
May 11, 2022
Scony
reviewed
May 11, 2022
…ly big Adds Warning when users try to bake a NavigationMesh with suspiciously big source geometry and small cellsizes as this baking process will likely fail or result in a NavigationMesh that will create serious pathfinding performance issues.
smix8
force-pushed
the
navmesh_bake_size_warning_4.x
branch
from
May 11, 2022 20:07
008f953
to
79511af
Compare
Scony
approved these changes
May 11, 2022
akien-mga
approved these changes
May 11, 2022
Thanks! |
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Considered for cherry-picking into a future 3.x release
label
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Warning when users try to bake a NavigationMesh with suspiciously big source geometry and small cellsizes as this baking process will likely fail in ReCast or result in a NavigationMesh that will create serious pathfinding performance issues and should not be used.
Closes #60907