Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Warning to NavigationMesh bake when source geometry is suspiciously big #60945

Merged
merged 1 commit into from
May 11, 2022

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented May 11, 2022

Adds Warning when users try to bake a NavigationMesh with suspiciously big source geometry and small cellsizes as this baking process will likely fail in ReCast or result in a NavigationMesh that will create serious pathfinding performance issues and should not be used.

Closes #60907

@Chaosus Chaosus added this to the 4.0 milestone May 11, 2022
@smix8 smix8 force-pushed the navmesh_bake_size_warning_4.x branch from 530fe3a to 736fd9a Compare May 11, 2022 13:56
@akien-mga akien-mga requested a review from AndreaCatania May 11, 2022 14:00
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 11, 2022
@akien-mga
Copy link
Member

CC @Scony

@smix8 smix8 force-pushed the navmesh_bake_size_warning_4.x branch from 198c22b to 4baf9dc Compare May 11, 2022 14:12
…ly big

Adds Warning when users try to bake a NavigationMesh with suspiciously big source geometry and small cellsizes as this baking process will likely fail or result in a NavigationMesh that will create serious pathfinding performance issues.
@smix8 smix8 force-pushed the navmesh_bake_size_warning_4.x branch from 008f953 to 79511af Compare May 11, 2022 20:07
@akien-mga akien-mga merged commit 516ec89 into godotengine:master May 11, 2022
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the navmesh_bake_size_warning_4.x branch May 11, 2022 21:31
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation fails to bake NavMesh if mesh is too large
4 participants