Portals - show gridmaps using global mode #60851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gridmaps did not previously show at all when portals were active, due to the instances being created defaulting to static mode, and not being converted during the room conversion stage.
This PR sets gridmap instances to global mode, which enables them to show up when portals are active (using frustum culling only, no occlusion).
Fixes #60833
(still needs documentation though)
Notes
The previous state of gridmaps showing was not so much a bug as a conscious decision to deter users from using this combination. However #60833 suggests there may be use cases.
Properly supporting gridmaps would likely either involve:
(1) Would probably not be a practical approach for such a special case, so (2) would be far more reasonable.
O(n)
culling).