Improve locking safety for RID handles builds #60427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional locks are added. This is primarily to cover a potential race condition where the pool is resized from another thread during a get operation.
Notes
rids=handles
andrids=tracked_handles
builds.Note that by design in Godot 3.x, the RID objects themselves aren't thread safe. The RID database itself is intended to be thread safe, but there's nothing to stop one thread e.g. deleting a RID object mid way while another thread is accessing that object.