Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention that Node's owner must be set for persistence to work #59254

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Mention that Node's owner must be set for persistence to work #59254

merged 1 commit into from
Mar 18, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 18, 2022

This is already done in Node.add_child() documentation, but this copies the note in Node.owner for good measure.

See #59253.

@Calinou Calinou requested a review from a team as a code owner March 18, 2022 00:27
@Calinou Calinou added enhancement documentation cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.4 labels Mar 18, 2022
@Calinou Calinou added this to the 4.0 milestone Mar 18, 2022
@akien-mga
Copy link
Member

You should use $DOCS_URL instead of hardcoding the docs URL (especially one that points to readthedocs.io instead of godotengine.org).

@Calinou
Mention that Node's owner must be set for persistence to work
be1acf3 
This is already done in `Node.add_child()` documentation, but
this copies the note in `Node.owner` for good measure.
@akien-mga akien-mga merged commit 9c231c2 into godotengine:master Mar 18, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the doc-node-owner branch March 18, 2022 19:09
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 22, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Calinou @akien-mga