-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify TextServer built-in module and GDExtension code. #58233
Conversation
6a08510
to
be83773
Compare
Some binary size stats: Editor
|
444a0a2
to
d570175
Compare
8b543db
to
e3b4bc4
Compare
af4ac8b
to
3c357f7
Compare
@@ -741,7 +741,7 @@ if selected_platform in platform_list: | |||
if env["minizip"]: | |||
env.Append(CPPDEFINES=["MINIZIP_ENABLED"]) | |||
|
|||
editor_module_list = ["freetype"] | |||
editor_module_list = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't really need the editor_module_list
logic now.
That being said, we could decide to make both regex
and svg
modules mandatory for the editor so I guess we can keep it for later use.
Thanks! |
Allows build the same
TextServer
code as a GDExtension or built-in module.String
operator+ char32_t
.String::num_int64
andString::num_uint64
methods to scripting.Image::create_from_data
andImage::create_empty
to C++.TextServer
interface GDExtension compatible.TextServer
implementation as GDExtension.TextServerDummy
, which is not capable of loading fonts and rendering text, but allows building Godot (including editor builds) without real text servers and FreeType.GDExtension modules depends on godotengine/godot-cpp#701, and require
extension_api.json
update to build.