Add DisplayServer.clipboard_has() to check clipboard content
#56949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 19, 2022
|
Makes sense. I'm not fond of the Yoda-speak names for |
m4gr3d
approved these changes
Jan 19, 2022
Comment on lines
+102
to
+106
| if (godot_java->has_has_clipboard()) { | ||
| return godot_java->has_clipboard(); | ||
| } else { | ||
| return DisplayServer::clipboard_has(); | ||
| } |
There was a problem hiding this comment.
I know this pattern is already in the code, but it seems incorrect to me as the default method implementation prints out a not supported warning, which is not the case in this scenario.
No actions needed on your part, I may just revisit this logic later and clean it up.
e3012f9 to
314f309
Compare
akien-mga
approved these changes
Jan 20, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way to check if there is anything to paste is to compare
clipboard_get()result with an empty string. However, on Android 12 and higher, the system usually shows a toast message when the app fetches the clipboard content:This is confusing & annoying if the user just want to check if there is anything to paste in order to update the UI.
This PR adds a
clipboard_has()method that checks clipboard content existence on Android without triggering the toast, and it simply returns!clipboard_get().is_empty()on other platforms.