Warn if the crash backtrace printed is missing debugging information #55565
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by the binary not including debugging symbols. Such backtraces generally not useful, as they don't pinpoint which file is the cause of the crash (let alone the line number).
See #55547 for an example where this message would help troubleshooting.
To test this PR locally, add a
CRASH_NOW();
call here and recompile: https://github.com/Calinou/godot/blob/24ad30b5141a2b9a078a11971a4c07e5cec68a95/editor/editor_node.cpp#L627Preview
With debug symbols
Without debug symbols
TODO