Rationalize Node removals and deletions #55512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
free()
andremove_child()
now behave the same: owner is kept duringtree_exiting
signal andnull
duringtree_exited
.tree_exited
is emitted in the same order astree_exiting
.Tested with the following composite scene (full project, where exact ownerships can be checked: Minimal.zip:
Main
's code:Results with current code (before this PR)
With
$A.free()
:With
remove_child($A)
:Results with this PR
With
$A.free()
orremove_child($A)
(same results in both cases):Supersedes #39835.
Fixes #22840.
NOTE: A non compat breaking subset of this PR for 3.x has been submitted separately: #55514.