Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more icons required for iOS export per new Apple guidelines #54010

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 19, 2021

This closes #53631.

Is 167×167 (iPad Pro) and 180×180 (iPhone @3x) required now?

@bruvzg
Copy link
Member

bruvzg commented Oct 20, 2021

https://developer.apple.com/design/human-interface-guidelines/ios/icons-and-images/app-icon/

Seems like they are - 180x180 + 120x120 (for iPhone), 167x167 + 152x152 (for iPad) and 1024x1024 (App Store). 76x76 is for the old non-Retina iPads.

But you can target iPad or iPhone only, in this case some icons are optional.

Maybe we should make all icons optional and enable icons/generate_missing by default.

@Calinou
Copy link
Member Author

Calinou commented Oct 20, 2021

Maybe we should make all icons optional and enable icons/generate_missing by default.

That sounds like a good idea. In fact, is there much of a point for disabling icons/generate_missing? If not, we could always enable it and rename the optional_icons section to icon_overrides. We'd only require setting one base icon (with the largest size).

@akien-mga akien-mga added this to the 4.0 milestone Oct 20, 2021
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 20, 2021
@akien-mga
Copy link
Member

Maybe we should make all icons optional and enable icons/generate_missing by default.

That sounds like a good idea. In fact, is there much of a point for disabling icons/generate_missing? If not, we could always enable it and rename the optional_icons section to icon_overrides. We'd only require setting one base icon (with the largest size).

Should we merge this PR, or implement this instead?

@akien-mga
Copy link
Member

Superseded by #56861.

@akien-mga akien-mga closed this Jan 17, 2022
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 17, 2022
@Calinou Calinou deleted the ios-export-make-more-icons-required branch January 17, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the required iOS icons to the correct one
3 participants