Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added primary clipboard for Linux #53702

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Added primary clipboard for Linux #53702

merged 1 commit into from
Oct 20, 2021

Conversation

ConteZero
Copy link
Contributor

@ConteZero ConteZero commented Oct 12, 2021 •
edited by akien-mga
Loading

This commit add support for primary clipboard on Linux to handle text paste with middle mouse button.
It should solve #3030

This is based on code originally written by @larpon, I fixed some bugs, added small improvements and updated the code to make it work with current master branch.

Bugsquad edit: Fixes godotengine/godot-proposals#3440.

@ConteZero ConteZero requested review from a team as code owners October 12, 2021 08:17
@Calinou Calinou added this to the 4.0 milestone Oct 12, 2021
Paulb23
Paulb23 requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on DisplayServer side, but overall looks okay.

One other thing to note, we should probably move the paste blocks into a method something like paste_primary_clipboard(). Then for TextEdit allow it to be overridden similar to paste().

@ConteZero ConteZero force-pushed the primary_clipboard_linux branch 5 times, most recently from c1f6470 to 8098535 Compare October 15, 2021 20:53
@ConteZero
Copy link
Contributor Author

@Paulb23 I've done some changes in how primary clipboard selection is handled to solve a bug in the previous code.

Paulb23
Paulb23 requested changes Oct 16, 2021
View reviewed changes
@ConteZero ConteZero force-pushed the primary_clipboard_linux branch from 8098535 to f40eb7f Compare October 16, 2021 20:21
@ConteZero
Copy link
Contributor Author

@Paulb23 I've also added a missing update() in rich_text_label

@ConteZero ConteZero force-pushed the primary_clipboard_linux branch from f40eb7f to fcabdb0 Compare October 17, 2021 06:10
Paulb23
Paulb23 approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI changes LGTM.

@ConteZero ConteZero force-pushed the primary_clipboard_linux branch from fcabdb0 to 838c9d3 Compare October 18, 2021 12:01
@ConteZero
Copy link
Contributor Author

I would like to send a pull request for the 3.x branch to backport this feature, can I do it or should I wait for this one to be merged?

@Calinou
Copy link
Member

Calinou commented Oct 20, 2021

I would like to send a pull request for the 3.x branch to backport this feature, can I do it or should I wait for this one to be merged?

You can open a 3.x version of this pull request now if you wish 🙂

@ConteZero ConteZero mentioned this pull request Oct 20, 2021
Merged
@akien-mga akien-mga merged commit 8748247 into godotengine:master Oct 20, 2021
@akien-mga
Copy link
Member

akien-mga commented Oct 20, 2021 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga mentioned this pull request Oct 20, 2021
Closed
@Chaosus Chaosus mentioned this pull request Oct 20, 2021
Closed
@larpon
Copy link
Contributor

larpon commented Oct 20, 2021

@ConteZero good job! Thanks for picking it up again 🤘🔥💪

@Calinou Calinou mentioned this pull request Dec 1, 2021
Merged
@ConteZero ConteZero deleted the primary_clipboard_linux branch March 15, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Paulb23 Paulb23 Paulb23 approved these changes

Assignees
No one assigned
Labels
enhancement platform:linuxbsd topic:gui topic:porting usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Implement middle-clicking to paste with primary clipboard in X11
5 participants
@ConteZero @Calinou @akien-mga @larpon @Paulb23