Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Fix crash when pinned SoftBody point is out of range #53380

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[3.x] Fix crash when pinned SoftBody point is out of range #53380

merged 1 commit into from
Oct 4, 2021

Conversation

timothyqiu
Copy link
Member

Fixes #53367

  • Validates parameters in setters.
  • Skip invalid pinned_nodes in setup_soft_body.
  • Adds missing p_ prefix to related parameter names.

@timothyqiu timothyqiu added this to the 3.4 milestone Oct 4, 2021
@timothyqiu timothyqiu requested a review from a team as a code owner October 4, 2021 08:33
@timothyqiu timothyqiu mentioned this pull request Oct 4, 2021
Merged
@akien-mga akien-mga merged commit b301514 into godotengine:3.x Oct 4, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Oct 4, 2021
Closed
@timothyqiu timothyqiu deleted the soft-body-3.x branch October 4, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:physics
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga